Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][FIX] helpdesk_mgmt: Fixes to automatic email sending according to stage #508

Merged
merged 1 commit into from
Oct 2, 2023
Merged

[15.0][FIX] helpdesk_mgmt: Fixes to automatic email sending according to stage #508

merged 1 commit into from
Oct 2, 2023

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Sep 28, 2023 •
edited
Loading

Fixes to automatic email sending according to stage:

  • Set stage_id in the ticket creation from portal so that _track_template() method has the correct behavior.
  • Set composition_mode=mass_mail so that the email is always sent (for example if the ticket is created from portal).

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT45288

@pedrobaeza pedrobaeza added this to the 15.0 milestone Sep 29, 2023
@victoralmau
[FIX] helpdesk_mgmt: Fixes to automatic email sending according to stage
c74bfe7 
- Set stage_id in the ticket creation from portal so that _track_template()
method has the correct behavior.
- Set composition_mode=mass_mail so that the email is always sent (for example
if the ticket is created from portal).

TT45288
@victoralmau victoralmau force-pushed the 15.0-fix-helpdesk_mgmt-TT45288 branch from 27be82f to c74bfe7 Compare October 2, 2023 10:40
pedrobaeza
pedrobaeza approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-508-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command git push origin 15.0-ocabot-merge-pr-508-by-pedrobaeza-bump-patch:15.0 failed with output:

To https://github.com/OCA/helpdesk
 ! [remote rejected] 15.0-ocabot-merge-pr-508-by-pedrobaeza-bump-patch -> 15.0 (cannot lock ref 'refs/heads/15.0': is at 7ce3de1388eec46b187b8d1b4e0ce81915a92b44 but expected 7d054ad62047403183770408bcf76c750cf3836b)
error: failed to push some refs to 'https://***@github.com/OCA/helpdesk'

@OCA-git-bot OCA-git-bot merged commit ed35abe into OCA:15.0 Oct 2, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7ce3de1. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-fix-helpdesk_mgmt-TT45288 branch October 2, 2023 11:00
@victoralmau victoralmau mentioned this pull request Oct 3, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@victoralmau @OCA-git-bot @chienandalu @pedrobaeza